RE: Review items for EXCEPT TABLE publication

Dear Vignesh, Chao,

> Finding #4: Test uses a stale subscription

Not critical, but DROP SUBSCRIPTION might be better to put before the DROP
PUBLICATION. Also related with the test, I feel below lines are not needed.

```
$node_subscriber->safe_psql('postgres', 'DROP SUBSCRIPTION tap_sub');
$node_publisher->safe_psql('postgres', 'DROP PUBLICATION tap_pub1');
$node_publisher->safe_psql('postgres', 'DROP PUBLICATION tap_pub2');

$node_publisher->stop('fast');
```

> > Finding #5: SET UNLOGGED on an excluded table produces an unrestorable
> > catalog state
> However, I have some concern about the design. Since a table in the EXCEPT
> list is not published anyway, do we really need to reject SET UNLOGGED? Would
> it make more sense to remove the table from the EXCEPT list and emit a NOTICE
> to inform the user?

I prefer the Vignesh's idea. For now publications are created with extactly given
settings, but your idea may break the existing rule. Can you raise existing
examples?

Best regards,
Hayato Kuroda
FUJITSU LIMITED