From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com> |
Subject: | Re: locking [user] catalog tables vs 2pc vs logical rep |
Date: | 2021-06-17 01:41:35 |
Message-ID: | CALDaNm1QemoSSmCyf-fKe4Y7UJ27MM=itcV+EFtU5wHm1E85CA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jun 16, 2021 at 3:51 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Jun 14, 2021 at 5:33 PM osumi(dot)takamichi(at)fujitsu(dot)com
> <osumi(dot)takamichi(at)fujitsu(dot)com> wrote:
> >
> > On Friday, June 11, 2021 2:13 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > Attached the patch-set that addressed those two comments.
> >
>
> Few minor comments:
> 1.
> + <listitem>
> + <para>
> + Clustering <structname>pg_class</structname> in a transaction.
>
> Can we change above to: Perform <command>CLUSTER</command> on
> <structname>pg_class</structname> in a transaction.
>
> 2.
> + <listitem>
> + <para>
> + Executing <command>TRUNCATE</command> on user catalog table
> in a transaction.
> + </para>
>
> Square brackets are missing for user.
>
> 3.
> + <indexterm>
> + <primary>Overview</primary>
> + </indexterm>
> ..
> ..
> + <indexterm>
> + <primary>Caveats</primary>
> + </indexterm>
>
> Why are these required when we already have titles? I have seen other
> places in the docs where we use titles for Overview and Caveats but
> they didn't have similar usage.
>
Even I felt this was not required. I had checked other places and also
prepared doc by removing it, it works fine.
Regards,
Vignesh
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2021-06-17 01:53:47 | Re: Teaching users how they can get the most out of HOT in Postgres 14 |
Previous Message | Tom Lane | 2021-06-17 01:39:49 | Centralizing protective copying of utility statements |