| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | "Wang, Shenhao" <wangsh(dot)fnst(at)cn(dot)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: handle a ECPG_bytea typo |
| Date: | 2020-07-25 01:52:15 |
| Message-ID: | CALDaNm1CSqdgOOU_kixrnJL0Rf0K4ZUbMzts1RCimF6S=vcE3A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 24, 2020 at 1:35 PM Wang, Shenhao
<wangsh(dot)fnst(at)cn(dot)fujitsu(dot)com> wrote:
>
> Hi, hackers
>
> The source looks like:
>
> case ECPGt_bytea:
> {
> struct ECPGgeneric_varchar *variable =
> (struct ECPGgeneric_varchar *) (var->value);
>
> ......
> }
>
> I think the developer intend to use struct ECPGgeneric_bytea instead of struct ECPGgeneric_varchar
>
> Is this thoughts right?
>
> I have wrote a patch to fix this typo
I felt the changes look correct. The reason it might be working
earlier is because the structure members are the same for both the
data structures ECPGgeneric_bytea & ECPGgeneric_varchar.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2020-07-25 03:40:08 | Re: Row estimates for empty tables |
| Previous Message | vignesh C | 2020-07-25 01:32:32 | Re: Parallel worker hangs while handling errors. |