| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Performance Improvement For Copy From Binary Files |
| Date: | 2020-07-12 13:13:31 |
| Message-ID: | CALDaNm1CNMh-DQF6-jGSQ4tYqT9rKFoCPpvT1s4sQ5Z+iULpHg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 10, 2020 at 8:51 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
>
> Hi Bharath,
> Here the numbers with the updated patch:
>
> HEAD patched (v2)
> foo5 8.5 6.1
> foo10 14 9.4
> foo20 25 16.7
>
Patch applies cleanly, make check & make check-world passes.
I had reviewed the changes. I felt one minor change required:
+ * CopyReadFromRawBuf
+ * Reads 'nbytes' bytes from cstate->copy_file via
cstate->raw_buf and
+ * writes then to 'saveTo'
+ *
+ * Useful when reading binary data from the file.
Should "writes then to 'saveTo'" be "writes them to 'dest'"?
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2020-07-12 13:18:47 | Re: calling procedures is slow and consumes extra much memory against calling function |
| Previous Message | Floris Van Nee | 2020-07-12 12:48:47 | RE: Index Skip Scan (new UniqueKeys) |