Re: [HACKERS] logical decoding of two-phase transactions

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Date: 2021-07-08 12:08:21
Message-ID: CALDaNm15ce8Qiz5WqaBMUyTMnQ=XCMz9NiAkh6LOo_+44uzi-A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 8, 2021 at 11:37 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Jul 6, 2021 at 9:58 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Please find attached the latest patch set v93*
> >
>
> Thanks, I have gone through the 0001 patch and made a number of
> changes. (a) Removed some of the code which was leftover from previous
> versions, (b) Removed the Assert in apply_handle_begin_prepare() as I
> don't think that makes sense, (c) added/changed comments and made a
> few other cosmetic changes, (d) ran pgindent.
>
> Let me know what you think of the attached?

The patch looks good to me, I don't have any comments.

Regards,
Vignesh

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2021-07-08 12:17:28 Re: pgbench logging broken by time logic changes
Previous Message kuroda.hayato@fujitsu.com 2021-07-08 11:42:14 RE: ECPG bug fix: DECALRE STATEMENT and DEALLOCATE, DESCRIBE