Re: [HACKERS] logical decoding of two-phase transactions

On Thu, Jul 8, 2021 at 10:08 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Thu, Jul 8, 2021 at 11:37 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Tue, Jul 6, 2021 at 9:58 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > >
> > > Please find attached the latest patch set v93*
> > >
> >
> > Thanks, I have gone through the 0001 patch and made a number of
> > changes. (a) Removed some of the code which was leftover from previous
> > versions, (b) Removed the Assert in apply_handle_begin_prepare() as I
> > don't think that makes sense, (c) added/changed comments and made a
> > few other cosmetic changes, (d) ran pgindent.
> >
> > Let me know what you think of the attached?
>
> The patch looks good to me, I don't have any comments.

I tried the v95-0001 patch.

- The patch applied cleanly and all build / testing was OK.
- The documentation also builds OK.
- I checked all v95-0001 / v93-0001 differences and found no problems.
- Furthermore, I noted that v95-0001 patch is passing the cfbot [1].

So this patch LGTM.

------
[1] http://cfbot.cputube.org/patch_33_2914.log

Kind Regards,
Peter Smith.
Fujitsu Australia