| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2025-10-06 11:03:42 |
| Message-ID: | CALDaNm0Q3fJMhyWLPgTuB_vsVSxwkczfYm4toZFH-57PiJWmpg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 6 Oct 2025 at 12:07, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Sat, 4 Oct 2025 at 21:24, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Tue, Sep 30, 2025 at 9:55 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > >
> >
> > In the 0001 patch, pg_get_sequence_data() exposes two new fields
> > log_cnt and page_lsn. I see that the later subscriber-side patch uses
> > both, the first one in SetSequence(). It is not clear from the
> > comments or the commit message of 0001 why it is necessary to use
> > log_cnt when setting the sequence. Can you explain what the problem
> > will be if we don't use log_cnt during sequence sync?
>
> I thought to keep the log_cnt value the same value as the publisher.
> I have verified from the upgrade that we don't retain the log_cnt
> value after upgrade, even if we copy log_cnt, the value will not be
> retained. The attached
> v20251006-0001-Enhance-pg_get_sequence_data-function.patch has the
> changes to remove log_cnt.
Here is the rebased remaining patches.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v20251006_2-0002-Reorganize-tablesync-Code-and-Introduce-.patch | application/octet-stream | 26.5 KB |
| v20251006_2-0001-Introduce-ALL-SEQUENCES-support-for-Post.patch | application/octet-stream | 111.2 KB |
| v20251006_2-0004-Introduce-REFRESH-PUBLICATION-SEQUENCES-.patch | application/octet-stream | 40.6 KB |
| v20251006_2-0003-Update-ALTER-SUBSCRIPTION-REFRESH-to-ALT.patch | application/octet-stream | 8.9 KB |
| v20251006_2-0005-New-worker-for-sequence-synchronization-.patch | application/octet-stream | 89.0 KB |
| v20251006_2-0006-Documentation-for-sequence-synchronizati.patch | application/octet-stream | 40.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2025-10-06 11:04:36 | Re: Should we update the random_page_cost default value? |
| Previous Message | Nazir Bilal Yavuz | 2025-10-06 10:44:10 | Re: split func.sgml to separated individual sgml files |