| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: StringInfo fixes, v19 edition. Plus a few oddities |
| Date: | 2026-04-27 06:44:36 |
| Message-ID: | CALDaNm0J0hmwCG_5NB3EMjuoYs91FaBy=9tH0BGn9ZJKdqfM2A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 27 Apr 2026 at 11:20, Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear hackers,
>
> Thanks for updating the patch. I have a concern for the handling of colon (:).
>
> In your patch a colon is used as the separator between data and sentence, and
> it's not included in the translatable message. The blank exists only after the
> colon.
>
> It seems to break syntax rules in other languages. E.g., the blank seems to be
> needed on both before and after the character in French [1]. In other language
> the colon may not be used in the first place.
>
> Based on that, How about including a colon in the translatable message?
> We may need additional if-else statement but it's a collateral damage.
Yeah, the better way is to go with if-else, the attached v4 version
patch has the changes for the same.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-replication-fix-translation-issues-in-tuple-value.patch | application/octet-stream | 13.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2026-04-27 07:02:16 | proposal: refactoring vacuum verbose output |
| Previous Message | Dilip Kumar | 2026-04-27 06:14:55 | Re: Support logical replication of DDLs, take2 |