From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
Subject: | Re: Logical Replication of sequences |
Date: | 2025-07-11 09:26:39 |
Message-ID: | CALDaNm0=1MnWJwWqOKSeirKyM4NSo7DrHjPQRPg+=7Pub0JZkQ@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, 9 Jul 2025 at 14:12, shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> Please find a few more comments on July4 patch
>
> 6)
> + <para>
> + To synchronize sequences from a publisher to a subscriber, first publish
> + them using <link linkend="sql-createpublication-params-for-all-sequences">
> + <command>CREATE PUBLICATION ... FOR ALL SEQUENCES</command></link>.
> + </para>
>
> This sentence looks odd, as we have 'first' but no follow-up sentence
> after that. Can we please combine this line with the next one in the
> doc saying:
>
> To synchronize sequences from a publisher to a subscriber, first
> publish them using CREATE PUBLICATION ... FOR ALL SEQUENCES and then
> at the subscriber side:
Modified
> 7)
>
> + <para>
> + This parameter is not applicable for sequences.
> + </para>
>
> It is mentioned 3 times in doc for publish, publish_generated_columns
> and publish_via_partition_root. Instead shall we mention it once for
> WITH-clause itself. Something like:
>
> This clause specifies optional parameters for a publication when
> publishing tables. This clause is not applicable for sequences.
Modified
> 8)
> + The view <structname>pg_publication_sequences</structname> provides
> + information about the mapping between publications and information of
> + sequences they contain.
>
> Why not:
> "The view pg_publication_sequences provides information about the
> mapping between publications and sequences."
>
> I think the existing detail has been written similar to
> 'pg_publication_tables' doc. But there, 'information of tables' made
> sense as pg_publication_tables has attnames and rowfilters too. But
> pg_publication_sequences OTOH just has
> the mapping between names. No other information.
Modified
> 9)
> + <sect2 id="sequence-definition-mismatches">
> + <title>Sequence Definition Mismatches</title>
> + <warning>
> + <para>
> + During sequence synchronization, the sequence definitions of the publisher
> + and the subscriber are compared.
>
> Now in code, we give WARNING for missing sequences on publisher as
> well. Do we need to mention that here? IIUC, this WARNING for missing
> sequences can come only if the worker is respawned to sync
> unmatched/failed sequences and meanwhile any one of failed sequences
> is dropped on publisher. But it will be good to mention it briefly in
> doc.
Modified
Also the comment from [1] is handled.
The attached v20250711 version patch has the changes for the same.
Regards,
Vignesh
Attachment | Content-Type | Size |
---|---|---|
v20250711-0003-Reorganize-tablesync-Code-and-Introduce-sy.patch | text/x-patch | 23.0 KB |
v20250711-0001-Introduce-pg_sequence_state-function-for-e.patch | text/x-patch | 7.3 KB |
v20250711-0004-Introduce-REFRESH-PUBLICATION-SEQUENCES-fo.patch | text/x-patch | 43.1 KB |
v20250711-0005-New-worker-for-sequence-synchronization-du.patch | text/x-patch | 73.0 KB |
v20250711-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch | text/x-patch | 104.8 KB |
v20250711-0006-Documentation-for-sequence-synchronization.patch | text/x-patch | 33.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | wenhui qiu | 2025-07-11 09:33:52 | Re: Small optimization with expanding dynamic hash table |
Previous Message | Bertrand Drouvot | 2025-07-11 09:23:40 | Re: Improve LWLock tranche name visibility across backends |