Re: Small optimization with expanding dynamic hash table

From: wenhui qiu <qiuwenhuifx(at)gmail(dot)com>
To: cca5507 <cca5507(at)qq(dot)com>
Cc: Rahila Syed <rahilasyed90(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Small optimization with expanding dynamic hash table
Date: 2025-07-11 09:33:52
Message-ID: CAGjGUA+szjkQvuccCJ2LZu99c6WX_2VY9TYxu9TJZUXSOkvREg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi
> The v2 patch maybe more clear:
> We can calc bucket just by hashvalue & high_mask when expanding table
because the if condition in calc_bucket() must be false.
I think you may add a comment to this path so that code reviewers can
clearly see your optimization.

Thanks

On Thu, Jul 10, 2025 at 10:46 AM cca5507 <cca5507(at)qq(dot)com> wrote:

> Hi,
>
> The v2 patch maybe more clear:
>
> We can calc bucket just by hashvalue & high_mask when expanding table
> because the if condition in calc_bucket() must be false.
>
> --
> Regards,
> ChangAo Chen
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shinya Kato 2025-07-11 09:37:56 Re: vacuumlazy: Modernize count_nondeletable_pages
Previous Message vignesh C 2025-07-11 09:26:39 Re: Logical Replication of sequences