Re: pg_publication_tables: return NULL attnames when no column list is specified

On Thu, Mar 26, 2026 at 10:07 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:

>
> Tested the patch and the patch fixes the bug as described. My tests below:
>

Thank you for the review.

<snip>

One observation from reviewing the patch: the test suite covers the
> partial column list and dropped column cases well, but is missing a
> test for the two-publication conflict scenario (one pub with no list +
> one pub with an explicit list of all columns on the same table). That
> is the breaking change called out in the original report and probably
> deserves its own regression test with a comment explaining the
> expected behavior change for users in that configuration.
> Patch LGTM otherwise.
>

Good point. I know I worked on that, so I must have accidentally dropped it
from the patch.

Will prepare a revision and submit.

Thanks again.

Roberto Mello
Snowflake

P.S.: I forgot to acknowledge and thank Greg Mullane for the initial review
on the patch, so doing that now.