Re: pg_publication_tables: return NULL attnames when no column list is specified

From: Roberto Mello <roberto(dot)mello(at)gmail(dot)com>
To: Ajin Cherian <itsajin(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_publication_tables: return NULL attnames when no column list is specified
Date: 2026-03-27 19:53:45
Message-ID: CAKz==bKd4jdbMhp5AxSk6R9v1fUubceqoOQ-AGM93gFEdgNWEg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 27, 2026 at 11:27 AM Roberto Mello <roberto(dot)mello(at)gmail(dot)com>
wrote:

> On Thu, Mar 26, 2026 at 10:07 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
>>
>> One observation from reviewing the patch: the test suite covers the
>> partial column list and dropped column cases well, but is missing a
>> test for the two-publication conflict scenario (one pub with no list +
>> one pub with an explicit list of all columns on the same table). That
>> is the breaking change called out in the original report and probably
>> deserves its own regression test with a comment explaining the
>> expected behavior change for users in that configuration.
>> Patch LGTM otherwise.
>>
>
> Good point. I know I worked on that, so I must have accidentally dropped
> it from the patch.
>
> Will prepare a revision and submit.
>

Here's v3 of the patch with the missing test.

Roberto Mello
Snowflake

Attachment Content-Type Size
v3-0001-Fix-pg_publication_tables-to-return-NULL-attnames.patch application/octet-stream 15.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-03-27 20:00:47 Re: Buffer locking is special (hints, checksums, AIO writes)
Previous Message Melanie Plageman 2026-03-27 19:31:04 Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)