| From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action |
| Date: | 2017-11-17 10:30:55 |
| Message-ID: | CAKKotZREVgBxENrV+OT6hnUUicXOXNHnXF36pcFadbEBUGL=OA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
PFA updated.
On Thu, Nov 16, 2017 at 5:12 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
> On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA minor patch to make error message uniform for 'Create schema' in both
>> query tool and create schema dialog.
>> RM#2094
>>
>
> The error message is definitely an improvement, but the dialogue title
> needs work:
>
> Error saving properties: GONE
>
> Why does it have : GONE on the end? That seems unhelpful.
>
That's coming from ajax statusText
<https://developer.mozilla.org/en-US/docs/Web/API/Response/statusText>, I
thought it was intended.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
| Attachment | Content-Type | Size |
|---|---|---|
| RM_2094_v1.diff | text/plain | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Paresh More | 2017-11-17 12:17:18 | [Patch]: Installer: pgAdmin4 should not install in special character path |
| Previous Message | Dave Page | 2017-11-17 10:17:11 | Re: Next release |