Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action
Date: 2017-11-16 11:42:45
Message-ID: CA+OCxowkeO7-A3ViYbWZNytbVQ2wKnUaipRfY9S8AcfHT+pp2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA minor patch to make error message uniform for 'Create schema' in both
> query tool and create schema dialog.
> RM#2094
>

The error message is definitely an improvement, but the dialogue title
needs work:

Error saving properties: GONE

Why does it have : GONE on the end? That seems unhelpful.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-11-16 11:56:08 pgAdmin 4 commit: Display long names appropriately in dialogue headers.
Previous Message Dave Page 2017-11-16 11:02:48 Re: [pgAdmin4][Patch]: Set focus on Filter window when opened by user