Re: Allowing extended stats on foreign and partitioned tables

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Subject: Re: Allowing extended stats on foreign and partitioned tables
Date: 2017-04-17 21:42:51
Message-ID: CAKJS1f_z=ThLU4iE7SHiS02-oMs4WFFFCLQ0N3hN=QvFrgzG=Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 18 April 2017 at 09:01, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> David Rowley wrote:
>> While reviewing extended stats I noticed that it was possible to
>> create extended stats on many object types, including sequences. I
>> mentioned that this should be disallowed. Statistics were then changed
>> to be only allowed on plain tables and materialized views.
>>
>> This should be relaxed again to allow anything ANALYZE is allowed on.
>>
>> The attached does this.
>
> The error message was inconsistent in the case of indexes, because of
> using heap_open instead of relation_open. That seemed gratuitous, so I
> flipped it, added test for the whole thing and pushed.

Thanks for changing that and pushing this.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2017-04-17 21:59:34 Re: extended stats not friendly towards ANALYZE with subset of columns
Previous Message Alvaro Herrera 2017-04-17 21:38:16 Re: pg_statistic_ext.staenabled might not be the best column name