Re: Allowing extended stats on foreign and partitioned tables

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Subject: Re: Allowing extended stats on foreign and partitioned tables
Date: 2017-04-17 21:01:29
Message-ID: 20170417210129.ztcy5lyfrdywmusp@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley wrote:
> While reviewing extended stats I noticed that it was possible to
> create extended stats on many object types, including sequences. I
> mentioned that this should be disallowed. Statistics were then changed
> to be only allowed on plain tables and materialized views.
>
> This should be relaxed again to allow anything ANALYZE is allowed on.
>
> The attached does this.

The error message was inconsistent in the case of indexes, because of
using heap_open instead of relation_open. That seemed gratuitous, so I
flipped it, added test for the whole thing and pushed.

Thanks for reporting.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2017-04-17 21:38:16 Re: pg_statistic_ext.staenabled might not be the best column name
Previous Message Andreas Karlsson 2017-04-17 20:42:54 Re: Self-signed certificate instructions