| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | hlinnaka(at)iki(dot)fi |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to improve a few appendStringInfo* calls |
| Date: | 2015-07-02 10:08:23 |
| Message-ID: | CAKJS1f_R74sqUEvEeHNe_TDyDqqPKttKerGOyzAX=XOfQ_Nx7A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2 July 2015 at 21:59, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> Applied the straightforward parts.
Thanks for committing.
> I left out the changes like
>
> - appendStringInfoString(&collist, buf.data);
>> + appendBinaryStringInfo(&collist, buf.data, buf.len);
>>
>
> because they're not an improvement in readablity, IMHO, and they were not
> in performance-critical paths.
>
>
Perhaps we can come up with appendStringInfoStringInfo at some later date.
--
David Rowley http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2015-07-02 10:46:59 | Re: Let PostgreSQL's On Schedule checkpoint write buffer smooth spread cycle by tuning IsCheckpointOnSchedule? |
| Previous Message | Heikki Linnakangas | 2015-07-02 09:59:15 | Re: Patch to improve a few appendStringInfo* calls |