Re: pgsql: Split ExecStoreTuple into ExecStoreHeapTuple and ExecStoreBuffer

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Split ExecStoreTuple into ExecStoreHeapTuple and ExecStoreBuffer
Date: 2018-11-10 11:30:51
Message-ID: CAKJS1f_MN+gsP_agATL5DGEVaMqwYa2u8U2JhjvzJoEoJ83qeg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 26 September 2018 at 11:39, Andres Freund <andres(at)anarazel(dot)de> wrote:
> src/backend/executor/nodeSeqscan.c | 11 ++-

The change made to the above file leaves a misleading comment about
passing false to ExecStoreTuple(). A similar mistake exists in
nodeIndexscan.c

A patch was posted to remove them in
https://www.postgresql.org/message-id/CAMyN-kCq+fDLUSEN+TmUkpn5YGQCyKKR266tyEnJjOd_WT-SDQ@mail.gmail.com

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2018-11-10 12:11:34 Re: pgsql: Remove ineffective check against dropped columns from slot_getat
Previous Message Andres Freund 2018-11-10 04:48:12 pgsql: Combine two flag tests in GetSnapshotData().