| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Remove ineffective check against dropped columns from slot_getat |
| Date: | 2018-11-10 12:11:34 |
| Message-ID: | CAKJS1f-F_hPnGh+bGygMy64t4osgY6M+sjW4ykvqmkxrdabL0Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 10 November 2018 at 14:41, Andres Freund <andres(at)anarazel(dot)de> wrote:
> These days locking and plan invalidation ought to ensure that dropped
> columns are not accessed in query plans. Therefore this commit just
> drops the insufficient check in slot_getattr(). It's possible that
> we'll find some holes againt use of dropped columns, but if so, those
> need to be addressed independent of slot_getattr(), as most accesses
> don't go through that function anyway.
Would it not be worth an Assert(!TupleDescAttr(tupleDesc, attnum -
1)->attisdropped); so that we're more likely to discover any issues
where cached plans are not invalidated correctly?
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-11-10 15:21:21 | pgsql: Remove dead foreign key optimization code |
| Previous Message | David Rowley | 2018-11-10 11:30:51 | Re: pgsql: Split ExecStoreTuple into ExecStoreHeapTuple and ExecStoreBuffer |