Re: pgsql: Support partition pruning at execution time

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Support partition pruning at execution time
Date: 2018-04-17 21:30:50
Message-ID: CAKJS1f_FGGb0mBNd49r-oNG9oKmMk2rahxpc9k0L=Jor5SNmeQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 18 April 2018 at 07:26, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> David Rowley wrote:
>
>> I've made another pass over the nodeAppend.c code and I'm unable to
>> see what might cause this, although I did discover a bug where
>> first_partial_plan is not set taking into account that some subplans
>> may have been pruned away during executor init. The only thing I think
>> this would cause is for parallel workers to not properly help out with
>> some partial plans if some earlier subplans were pruned. I can see no
>> reason for this to have caused this particular issue since the
>> first_partial_plan would be 0 with and without the attached fix.
>
> Pushed this.

Thanks!

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-04-17 22:29:26 pgsql: Rationalize handling of array type names in bootstrap data.
Previous Message Heikki Linnakangas 2018-04-17 20:15:08 Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2018-04-17 21:32:45 Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS
Previous Message David Rowley 2018-04-17 21:30:11 Re: Append's first_partial_plan