| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding |
| Date: | 2018-04-17 20:15:08 |
| Message-ID: | 6a9bcfd5-880d-9442-fed2-695ba8ef50f3@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 10/04/18 03:24, Michael Paquier wrote:
> + /* twophase_gid follows if XINFO_HAS_GID. As a null-terminated string. */
> + /* xl_xact_origin follows if XINFO_HAS_ORIGIN, stored unaligned! */
>
> Worth mentioning that the first one is also unaligned with your patch?
Hmm. 'twophase_gid' is actually 4-byte aligned here. But it's a string,
so it doesn't matter whether it it is or not.
> And that all the last fields of xl_xact_commit and xl_xact_abort are
> kept as such on purpose?
I think that's clear without an explicit comment. If it wasn't on
purpose, we wouldn't have a comment pointing it out (or we would fix it
so that it was aligned).
Pushed, thanks for the review!
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-04-17 21:30:50 | Re: pgsql: Support partition pruning at execution time |
| Previous Message | Heikki Linnakangas | 2018-04-17 20:11:10 | pgsql: Fix confusion on the padding of GIDs in on commit and abort reco |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-04-17 20:18:50 | Re: partitioning code reorganization |
| Previous Message | Andres Freund | 2018-04-17 20:14:58 | Re: Setting rpath on llvmjit.so? |