From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
---|---|
To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] path toward faster partition pruning |
Date: | 2018-02-28 11:35:01 |
Message-ID: | CAKJS1f9kzQY2W1aMmJ0LbX5bygWYR+usssOu=hRhvKn0TUGqUQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 27 February 2018 at 22:33, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Attached an updated version in which I incorporated some of the revisions
> that David Rowley suggested to OR clauses handling (in partprune.c) that
> he posted as a separate patch on the run-time pruning thread [1].
Thanks for fixing that up and including it.
Micro review of v34:
1. Looks like you've renamed the parttypid parameter in the definition
of partkey_datum_from_expr and partition_cmp_args, but not updated the
declaration too.
+static bool partkey_datum_from_expr(Oid parttypid, Expr *expr, Datum *value);
+static bool
+partkey_datum_from_expr(Oid partopcintype, Expr *expr, Datum *value)
+static bool partition_cmp_args(Oid parttypid, Oid partopfamily,
+ PartClause *pc, PartClause *leftarg, PartClause *rightarg,
+ bool *result);
+static bool
+partition_cmp_args(Oid partopcintype, Oid partopfamily,
+ PartClause *pc, PartClause *leftarg, PartClause *rightarg,
+ bool *result)
2. In prune_append_rel_partitions(), it's not exactly illegal, but int
i is declared twice in different scopes. Looks like there's no need
for the inner one.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Anastasia Lubennikova | 2018-02-28 12:11:33 | Function to track shmem reinit time |
Previous Message | Ashutosh Bapat | 2018-02-28 11:25:47 | Re: [HACKERS] path toward faster partition pruning |