Re: Some incorrect comments and out-dated README from run-time pruning

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Some incorrect comments and out-dated README from run-time pruning
Date: 2018-10-09 20:25:00
Message-ID: CAKJS1f-uJ4AOC=BhHjPPi2YPFDF5YXinfdbLSQze_CS48+pROQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10 October 2018 at 02:38, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> - * subplan_map[] and subpart_map[] are indexed by partition index (where
> - * zero is the topmost partition, and non-leaf partitions must come before
> - * their children). For a leaf partition p, subplan_map[p] contains the
> + * subplan_map[] and subpart_map[] are indexed by partition index (as
> defined
> + * in the PartitionDesc). For a leaf partition p, subplan_map[p]
> contains the
>
> I don't see what someone reading this comment would do with "as defined
> in the PartitionDesc". I don't see any PartitionDesc referenced or
> mentioned at or near that struct.

Perhaps it should have mentioned: the PartitionDesc belonging to the
partitioned table referenced by 'rtindex'.

I've attached another version.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
various_run-time_pruning_doc_fixes_v2.patch application/octet-stream 3.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2018-10-09 20:26:58 Re: Support custom socket directory in pg_upgrade
Previous Message Thomas Munro 2018-10-09 20:15:26 Re: [HACKERS] Why does logical replication launcher exit with exit code 1?