From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Some incorrect comments and out-dated README from run-time pruning |
Date: | 2018-10-09 13:38:18 |
Message-ID: | 4f3dfccd-1f2c-4fe7-e534-f22d6a56ab26@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 27/09/2018 23:20, David Rowley wrote:
> I've noticed that the comments above the PartitionedRelPruneInfo
> struct incorrectly document how subplan_map and subpart_map are
> indexed. This seems to have snuck in on 4e232364033.
- * subplan_map[] and subpart_map[] are indexed by partition index (where
- * zero is the topmost partition, and non-leaf partitions must come before
- * their children). For a leaf partition p, subplan_map[p] contains the
+ * subplan_map[] and subpart_map[] are indexed by partition index (as
defined
+ * in the PartitionDesc). For a leaf partition p, subplan_map[p]
contains the
I don't see what someone reading this comment would do with "as defined
in the PartitionDesc". I don't see any PartitionDesc referenced or
mentioned at or near that struct.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-10-09 13:41:52 | Re: Function for listing archive_status directory |
Previous Message | Arun Kumar | 2018-10-09 13:10:20 | Requesting advanced Group By support |