| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Some incorrect comments and out-dated README from run-time pruning |
| Date: | 2018-11-15 22:13:32 |
| Message-ID: | 2a1a4b45-dab5-433e-c2dc-d4e9abd51afb@2ndquadrant.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09/10/2018 22:25, David Rowley wrote:
> On 10 October 2018 at 02:38, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> - * subplan_map[] and subpart_map[] are indexed by partition index (where
>> - * zero is the topmost partition, and non-leaf partitions must come before
>> - * their children). For a leaf partition p, subplan_map[p] contains the
>> + * subplan_map[] and subpart_map[] are indexed by partition index (as
>> defined
>> + * in the PartitionDesc). For a leaf partition p, subplan_map[p]
>> contains the
>>
>> I don't see what someone reading this comment would do with "as defined
>> in the PartitionDesc". I don't see any PartitionDesc referenced or
>> mentioned at or near that struct.
>
> Perhaps it should have mentioned: the PartitionDesc belonging to the
> partitioned table referenced by 'rtindex'.
>
> I've attached another version.
Committed and backpatched to PG11.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2018-11-15 22:15:07 | Re: Range phrase operator in tsquery |
| Previous Message | Tom Lane | 2018-11-15 22:06:36 | Re: Pull up sublink of type 'NOT NOT (expr)' |