| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Confusing error message for REINDEX TABLE CONCURRENTLY |
| Date: | 2019-05-28 19:04:46 |
| Message-ID: | CAKJS1f-HNkfkYm2QpUP4kcK5KO8WwzvsxJ4zGo3HV6-p-WAetA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 28 May 2019 at 01:23, Ashwin Agrawal <aagrawal(at)pivotal(dot)io> wrote:
> I think we will need to separate out the NOTICE message for concurrent and regular case.
>
> For example this doesn't sound correct
> WARNING: cannot reindex exclusion constraint index "public.circles_c_excl" concurrently, skipping
> NOTICE: table "circles" has no indexes to reindex
>
> As no indexes can't be reindexed *concurrently* but there are still indexes which can be reindexed, invalid indexes I think fall in same category.
Swap "can't" for "can" and, yeah. I think it would be good to make the
error messages differ for these two cases. This would serve as a hint
to the user that they might have better luck trying without the
"concurrently" option.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-05-28 19:27:57 | Re: Quick doc typo fix |
| Previous Message | Thomas Munro | 2019-05-28 19:00:00 | Re: Collation versioning |