| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, amul sul <sulamul(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] Runtime Partition Pruning |
| Date: | 2018-04-07 02:26:25 |
| Message-ID: | CAKJS1f-42TXEo1DLZ_FXBNiRuJ3=Oy-Z5V8_0WkL0_Ast=9saw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7 April 2018 at 12:03, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> Continuing to read 0003 and 0004 now.
0003:
1. "setup" -> "set"
/* If run-time partition pruning is enabled, then setup that up now */
2. We should be able to get rid of as_noopscan and just have another
special negative value for as_whichplan.
I've attached a patch to do this.
3. I've forgotten to drop table boolvalues in the tests.
Patched attached to fix.
0004:
1. "ms_valid_subplans" -> "valid_subplans" in:
* ms_valid_subplans for runtime pruning, valid mergeplans indexes to
* scan.
All the other fields are not being prefixed with ms_ in these comments.
Everything else looks fine from my point of view.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| nodeAppend_get_rid_of_as_noopscan.patch | application/octet-stream | 5.9 KB |
| drop_table_boolvalues.patch | application/octet-stream | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-04-07 02:42:53 | Re: [HACKERS] path toward faster partition pruning |
| Previous Message | Stephen Frost | 2018-04-07 02:22:20 | Re: PATCH: Configurable file mode mask |