Re: [BUGFIX] amcanbackward is not checked before building backward index paths

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGFIX] amcanbackward is not checked before building backward index paths
Date: 2018-05-17 16:08:23
Message-ID: CAKFQuwbjw-fcbMBbOER_cg+TpUtp08fyJDmS2xFp3O_oQW+q4g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 17, 2018 at 8:46 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
> > I'll fix the docs accordingly. I'm referring specifically to this bit:
> > https://www.postgresql.org/docs/current/static/functions-
> info.html#FUNCTIONS-INFO-INDEX-PROPS
> > which I think should say "Can the scan direction be changed in
> > mid-scan?" in place of the current text (unless anyone has better
> > wording?)
>
> Maybe "Can the scan direction be reversed in mid-scan?". I'm not
> absolutely sure that that's better ...
>

​A cursory read might conclude that "reversing" can only happen once while
they will likely understand that "changing" can happen multiple times.
This is minor point - the two are effectively the same.

Maybe: "Supports both FETCH FORWARD and FETCH BACKWARD during the same scan"

Or:

"Supports SCROLL(able) WITHOUT HOLD cursors"

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-05-17 16:17:43 Re: [BUGFIX] amcanbackward is not checked before building backward index paths
Previous Message Tom Lane 2018-05-17 15:46:22 Re: [BUGFIX] amcanbackward is not checked before building backward index paths