Re: [BUGFIX] amcanbackward is not checked before building backward index paths

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGFIX] amcanbackward is not checked before building backward index paths
Date: 2018-05-17 16:17:43
Message-ID: 28000.1526573863@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> On Thu, May 17, 2018 at 8:46 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Maybe "Can the scan direction be reversed in mid-scan?". I'm not
>> absolutely sure that that's better ...

> ​A cursory read might conclude that "reversing" can only happen once while
> they will likely understand that "changing" can happen multiple times.
> This is minor point - the two are effectively the same.
> Maybe: "Supports both FETCH FORWARD and FETCH BACKWARD during the same scan"

Oh, yeah, mentioning what it's *for* would help clarify things, no?
So perhaps

"Can the scan direction be changed in mid-scan (to support FETCH FORWARD
and FETCH BACKWARD on a cursor)?"

> Or:
> "Supports SCROLL(able) WITHOUT HOLD cursors"

That seems a bit more vague/indirect.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-05-17 16:20:01 Re: Infinite loop on master shutdown
Previous Message David G. Johnston 2018-05-17 16:08:23 Re: [BUGFIX] amcanbackward is not checked before building backward index paths