Re: [COMMITTERS] pgsql: Doc: improve documentation about composite-value usage.

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Doc: improve documentation about composite-value usage.
Date: 2016-11-22 23:35:28
Message-ID: CAKFQuwbUcXwY+wysARzvYSGq0nbiV9qKDH_XKBBNwGrQgP9O-w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Nov 22, 2016 at 3:56 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Doc: improve documentation about composite-value usage.
>
> Create a section specifically for the syntactic rules around whole-row
> variable usage, such as expansion of "foo.*". This was previously
> documented only haphazardly, with some critical info buried in
> unexpected places like xfunc-sql-composite-functions. Per repeated
> questions in different mailing lists.
>

​Tom,​

​I found it notable that you choose to introduce the OFFSET 0 hack instead
of writing a LATERAL query in the "optimization failure" example.​

SELECT (m).* FROM (SELECT myfunc(x) AS m FROM some_table OFFSET 0) ss;

instead of​

SELECT (m).* FROM some_table, LATERAL myfunc(some_table.x) m

​​Skipping or having a different example in 9.2 seems worth it in order to
introduce the now preferred way of writing such queries.

Or maybe in addition, so that some familiarity with the hack is gained
should the reader encounter it in the wild.

David J.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-11-23 01:28:38 pgsql: Remove barrier.h
Previous Message Tom Lane 2016-11-22 23:07:54 pgsql: Doc: in back branches, don't call it a row constructor if it isn

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2016-11-22 23:52:22 Re: macaddr 64 bit (EUI-64) datatype support
Previous Message Haribabu Kommi 2016-11-22 23:30:27 Re: commitfest 2016-11 status summary