Re: Unable parse a comment in gram.y

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Unable parse a comment in gram.y
Date: 2024-06-23 04:13:37
Message-ID: CAKFQuwb45GhK16nfkWAb2o_6NsJ6LE9OCRG67aAemNsCZTqQbQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:

> I was unable to parse a comment in src/backend/parser/gram.y around line
> 11364:
>
> /*
> * As func_expr but does not accept WINDOW functions directly (they
> * can still be contained in arguments for functions etc.)
> * Use this when window expressions are not allowed, so to disambiguate
> * the grammar. (e.g. in CREATE INDEX)
> */
>
> Maybe "but" is unnecessary in the first sentence in the comment?
>
>
The "but" is required, add a comma before it. It could also be written a
bit more verbosely:

func_expr_windowless is the same as func_expr aside from not accepting
window functions directly ...

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2024-06-23 04:22:10 Re: Unable parse a comment in gram.y
Previous Message Tatsuo Ishii 2024-06-23 04:01:54 Unable parse a comment in gram.y