From: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
---|---|
To: | david(dot)g(dot)johnston(at)gmail(dot)com |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Unable parse a comment in gram.y |
Date: | 2024-06-23 04:22:10 |
Message-ID: | 20240623.132210.1630094051923975593.t-ishii@sranhm.sra.co.jp.sranhm |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:
>
>> I was unable to parse a comment in src/backend/parser/gram.y around line
>> 11364:
>>
>> /*
>> * As func_expr but does not accept WINDOW functions directly (they
>> * can still be contained in arguments for functions etc.)
>> * Use this when window expressions are not allowed, so to disambiguate
>> * the grammar. (e.g. in CREATE INDEX)
>> */
>>
>> Maybe "but" is unnecessary in the first sentence in the comment?
>>
>>
> The "but" is required, add a comma before it. It could also be written a
> bit more verbosely:
>
> func_expr_windowless is the same as func_expr aside from not accepting
> window functions directly ...
Oh, I see.
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2024-06-23 04:41:29 | Re: Unable parse a comment in gram.y |
Previous Message | David G. Johnston | 2024-06-23 04:13:37 | Re: Unable parse a comment in gram.y |