| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: docs: clarify ALTER TABLE behavior on partitioned tables |
| Date: | 2026-01-28 22:21:13 |
| Message-ID: | CAKFQuwa9E+k_VekEeP1syJg2qAzTLGcO6qexPAuMZeSEZE9-QA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 26, 2026 at 3:42 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> PFA v8.
>
>
Delta:
Added missing literal element for ONLY
Expanded usage of "propagates" wording and made it active voice
Fixed wording of "partitioned table and/or partitions" to be more correct
and succinct: "parent and individual partitions"
Modified the 'sequences' wording to try and make it more obvious that every
partition has its own sequence that is affected rather than a single
sequence for the entire partitioned table.
Note, I think the base patch should have all the isolated
newlines-between-para changes removed from it. If anything, the more
common, and for me more readable, flow is to have those line breaks. In any
case, the file is not consistent on one or the other before or after these
unrelated fixes so we shouldn't be making them. For new paragraphs,
matching the block they are added in works - and if adding the second
paragraph I'd include a newline.
Note, the convention is to use two spaces after a full stop (period). Not
too worried about this one here, just an FYI.
David J.
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0002-diff-over-v8.patch | text/x-patch | 11.2 KB |
| v9-0001-docs-clarify-ALTER-TABLE-behavior-on-partitioned-.patch | text/x-patch | 33.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-01-28 22:33:49 | Re: Refactor replication origin state reset helpers |
| Previous Message | Álvaro Herrera | 2026-01-28 21:48:45 | Re: Race conditions in logical decoding |