Re: docs: clarify ALTER TABLE behavior on partitioned tables

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Subject: Re: docs: clarify ALTER TABLE behavior on partitioned tables
Date: 2026-01-29 01:43:40
Message-ID: B0411EAD-E70E-483E-B9D5-0D4639CB28F7@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Jan 29, 2026, at 06:21, David G. Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>
> On Mon, Jan 26, 2026 at 3:42 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> PFA v8.
>
>
> Delta:
>
> Added missing literal element for ONLY

Accepted.

> Expanded usage of "propagates" wording and made it active voice

I doubt this change. But as a non-English speaker, I don’t want to argue about English, so, I will just accept the change.

> Fixed wording of "partitioned table and/or partitions" to be more correct and succinct: "parent and individual partitions"

Accepted.

> Modified the 'sequences' wording to try and make it more obvious that every partition has its own sequence that is affected rather than a single sequence for the entire partitioned table.

Accepted.

>
> Note, I think the base patch should have all the isolated newlines-between-para changes removed from it. If anything, the more common, and for me more readable, flow is to have those line breaks. In any case, the file is not consistent on one or the other before or after these unrelated fixes so we shouldn't be making them. For new paragraphs, matching the block they are added in works - and if adding the second paragraph I'd include a newline.

Yeah, I actually inclined to have a newline between paragraphs, but the doc already contains inconsistent styles, so I just tried to follow surrounding paragraphs’ style to decide if a new line needed.

>
> Note, the convention is to use two spaces after a full stop (period). Not too worried about this one here, just an FYI.
>

Thanks for the information.

PFA v10 - just integrated v9-0002-diff into the patch.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Attachment Content-Type Size
v10-0001-docs-clarify-ALTER-TABLE-behavior-on-partitioned.patch application/octet-stream 33.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2026-01-29 01:59:45 Re: docs: clarify ALTER TABLE behavior on partitioned tables
Previous Message Tom Lane 2026-01-29 01:36:37 Re: AIX support