Re: Regression failures after changing PostgreSQL blocksize

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Alexandre Felipe <o(dot)alexandre(dot)felipe(at)gmail(dot)com>
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Yasir <yasir(dot)hussain(dot)shah(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Zhang Mingli <zmlpostgres(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Regression failures after changing PostgreSQL blocksize
Date: 2026-02-22 02:19:10
Message-ID: CAKFQuwYn4+vPrZxndAbxkW=nkAmOjt+rO5KBLnH4WGWK-RApig@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Saturday, February 21, 2026, Alexandre Felipe <
o(dot)alexandre(dot)felipe(at)gmail(dot)com> wrote:

>
> (I personally think that we could have the input and expected output in
> one single file).
>

Even if we could why would that be an improvement - green-field, let alone
the motivation for refactoring.

By default it ignores comments and spaces, and in the expected file you can
> enable/disable other things, e.g. ignoring numbers in specific lines would
> probably help with the 32kB failures.
>

What’s the minimum functionality you’d need to get block size variances to
be auto-accepted using existing expected outputs. Most/all of what you’ve
decided to allow to be ignored has no variability based on setting values
or environment - and likely would be stuff we wouldn’t want to be optional
(i.e., you need to justify each option). And there is no demonstration of
actually solving the problem at hand.

I’d also go for an approach like: if block size <> 8kb then re-process any
exception output diffs/files again using the looser constraints.
Otherwise, stop and report test failure (status quo). I’d be against
applying these kinds of bypasses to stock configured PostgreSQL for which a
complete set of copy-and-pasted expected files need to exist.

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-02-22 03:40:10 Re: BUG #19393: pg_upgrade fails with duplicate key violation when CHECK constraint named *_not_null exists
Previous Message Alexandre Felipe 2026-02-22 00:47:39 Re: Regression failures after changing PostgreSQL blocksize