| From: | Alexandre Felipe <o(dot)alexandre(dot)felipe(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Yasir <yasir(dot)hussain(dot)shah(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Zhang Mingli <zmlpostgres(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Regression failures after changing PostgreSQL blocksize |
| Date: | 2026-02-22 00:47:39 |
| Message-ID: | CAE8JnxP0js27RrunxXktvfmnum7csoBe2q_R+sj08hoqDNG3Zg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Álvaro,
I think we can make it work
I just noticed that pg_regress provisioned `get_alternative_expectfile` for
that, and I see examples like `char{,_1,_2}.out`, but that is horrible for
maintenance (I personally think that we could have the input and expected
output in one single file).
I added a patch that would support selective matching. Check the README.md,
it contains some human readable instructions that I also used to test the
implementation. `make self-test` extracts examples from README.md and
runs pg_regress on them, i.e. test the implementation on the documentation.
https://asciinema.org/a/lFzGnv73mmOqyLWw
By default it ignores comments and spaces, and in the expected file you can
enable/disable other things, e.g. ignoring numbers in specific lines would
probably help with the 32kB failures.
Regards,
Alexandre
On Fri, Feb 20, 2026 at 9:42 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> On 2026-Feb-20, Alexandre Felipe wrote:
>
> > What about pattern matching? being able to write regular expressions on
> the
> > expected outputs?
>
> I doubt that will work.
>
> --
> Álvaro Herrera 48°01'N 7°57'E —
> https://www.EnterpriseDB.com/
> "Entristecido, Wutra (canción de Las Barreras)
> echa a Freyr a rodar
> y a nosotros al mar"
>
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Relaxed-matching-in-regress.patch | application/octet-stream | 26.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2026-02-22 02:19:10 | Re: Regression failures after changing PostgreSQL blocksize |
| Previous Message | Nathan Bossart | 2026-02-21 21:23:19 | Re: refactor architecture-specific popcount code |