From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
---|---|
To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Improve docs for n_distinct_inherited |
Date: | 2025-10-13 11:55:36 |
Message-ID: | CAKFQuwYhKU3s98vRF0RgVfkDAsyhAhRv6uz2ttjHAviz_thijg@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Monday, October 13, 2025, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Mon, 13 Oct 2025 at 17:09, David G. Johnston
> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> > How about:
> >
> > n_distinct_inherited exists to allow the distinct value estimate to be
> overwritten for the children-included statistics gathered for inheritance
> parent tables, and for partitioned tables.
> >
> > I can live with “ordinarily” with that wording, it is just the negative
> of “children-included”.
>
> I've ended up reverting the text back to become more similar to how it
> was but explicitly adding ", and for the statistics gathered for
> partitioned tables.", since that's what the original bug report was
> confused about.
>
> I've kept the other document changes as they were in the previous patch.
>
WFM. Since we allow 0 as an input I’m not convinced we should remove that
sentence, though I concur that using reset is preferred.
David J.
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2025-10-13 12:30:17 | Build failure with Meson >= 1.8.3 on Windows |
Previous Message | Amit Kapila | 2025-10-13 11:48:32 | Re: [PATCH TEST] Fix logical replication setup in subscription test `t/009_matviews.pl` |