Re: [PATCH] Add section headings to index types doc

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Jürgen Purtz <juergen(at)purtz(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add section headings to index types doc
Date: 2020-10-21 21:12:03
Message-ID: CAKFQuwYEx+4qwrLJ0ne6vaJef1eurrvL2rv7TDcgcpfLOQA02Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 30, 2020 at 4:25 AM Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
wrote:

> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>
> > On Mon, Aug 10, 2020 at 12:52:17PM +0000, Jürgen Purtz wrote:
> >> The new status of this patch is: Waiting on Author
> >
> > This has not been answered yet, so I have marked the patch as returned
> > with feedback.
>
> Updated patch attached, wich reformats the operator lists as requested
> by Jürgen,

A couple of things:

One, I would place the equality operator for hash inside a standalone
synopsis just like all of the others.
Two, why is hash special in having its create index command provided here?
(I notice this isn't the fault of this patch but it stands out when
reviewing it)

I would suggest rewording hash to look more like the others and add a link
to the "CREATE INDEX" command from the chapter preamble.

and skips the reindentation as suggested by Tom.
>

Agreed
David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2020-10-21 21:22:32 Re: language cleanups in code and docs
Previous Message Tomas Vondra 2020-10-21 21:00:05 Re: Use of "long" in incremental sort code