| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: language cleanups in code and docs |
| Date: | 2020-10-21 21:22:32 |
| Message-ID: | CA+hUKGJnN6zWisrOAznSd6O_+WAhCqRwFq4jQowbLtTh-jUihg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 17, 2020 at 10:32 PM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> In looking at this I realize we also have exactly one thing referred to as "blacklist" in our codebase, which is the "enum blacklist" (and then a small internal variable in pgindent). AFAICT, it's not actually exposed to userspace anywhere, so we could probably make the attached change to blocklist at no "cost" (the only thing changed is the name of the hash table, and we definitely change things like that in normal releases with no specific thought on backwards compat).
+1
Hmm, can we find a more descriptive name for this mechanism? What
about calling it the "uncommitted enum table"? See attached.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Rename-enum-blacklist-to-uncommitted-enum-table.patch | text/x-patch | 11.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anastasia Lubennikova | 2020-10-21 21:47:03 | Re: [patch] Fix checksum verification in base backups for zero page headers |
| Previous Message | David G. Johnston | 2020-10-21 21:12:03 | Re: [PATCH] Add section headings to index types doc |