Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DROP relation IF EXISTS Docs and Tests - Bug Fix
Date: 2020-07-14 16:01:24
Message-ID: CAKFQuwYEY9ntTf7ckhtyH2=DJo6T6pwBB3LqRE_OFYsUgVKkfw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 14, 2020 at 7:21 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
wrote:

> út 14. 7. 2020 v 16:09 odesílatel David G. Johnston <
> david(dot)g(dot)johnston(at)gmail(dot)com> napsal:
>
>> On Tue, Jul 14, 2020 at 6:56 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
>> wrote:
>>
>>> út 14. 7. 2020 v 15:55 odesílatel David G. Johnston <
>>> david(dot)g(dot)johnston(at)gmail(dot)com> napsal:
>>>
>>>> Further comments welcome so I'm putting it back into needs review for
>>>> the moment while I work on the refactor.
>>>>
>>>
>>> attached fixed patch
>>>
>>> all tests passed
>>> doc build without problems
>>>
>>
>> Thanks.
>>
>> Actually, one question I didn't pose before, does the SQL standard define
>> DROP TYPE to target domains while also providing for a DROP DOMAIN
>> command? Do drop commands for the other types we have not exist because
>> those aren't SQL standard types (or the standard they are standard types
>> but the commands aren't defined)?
>>
>
> It looks like Postgres user defined types are something else than ANSI SQL
> - so CREATE TYPE and DROP TYPE did different work.
>
> In the section DROP TYPE in ANSI SQL there is not mentioned any relation
> to domains.
>

Attaching a backpatch-able patch for the main docs and tests, v4
Added a head-only patch for the glossary changes, set to v4 as well.

I didn't try and address any SQL standard dynamics here.

David J.

Attachment Content-Type Size
001-drop-if-exists-docs-and-tests-v4.patch application/octet-stream 21.5 KB
002-types-glossary-v4.patch application/octet-stream 7.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2020-07-14 16:08:46 Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Previous Message Alexey Kondratov 2020-07-14 15:12:09 Re: Partitioning and postgres_fdw optimisations for multi-tenancy