Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DROP relation IF EXISTS Docs and Tests - Bug Fix
Date: 2020-07-14 14:20:43
Message-ID: CAFj8pRCc36pe5QYz1Ld9z-MANreONOAXhqQ7SoYL2h4XnYzitQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

út 14. 7. 2020 v 16:09 odesílatel David G. Johnston <
david(dot)g(dot)johnston(at)gmail(dot)com> napsal:

> On Tue, Jul 14, 2020 at 6:56 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
>
>> út 14. 7. 2020 v 15:55 odesílatel David G. Johnston <
>> david(dot)g(dot)johnston(at)gmail(dot)com> napsal:
>>
>>> Further comments welcome so I'm putting it back into needs review for
>>> the moment while I work on the refactor.
>>>
>>
>> attached fixed patch
>>
>> all tests passed
>> doc build without problems
>>
>
> Thanks.
>
> Actually, one question I didn't pose before, does the SQL standard define
> DROP TYPE to target domains while also providing for a DROP DOMAIN
> command? Do drop commands for the other types we have not exist because
> those aren't SQL standard types (or the standard they are standard types
> but the commands aren't defined)?
>

It looks like Postgres user defined types are something else than ANSI SQL
- so CREATE TYPE and DROP TYPE did different work.

In the section DROP TYPE in ANSI SQL there is not mentioned any relation to
domains.

> David J.
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2020-07-14 14:21:11 Re: recovering from "found xmin ... from before relfrozenxid ..."
Previous Message Pavel Stehule 2020-07-14 14:11:36 Re: [Proposal] Global temporary tables