Re: pgsql: Increase test coverage in RI_FKey_pk_upd_check_required()

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: "pgsql-committers(at)lists(dot)postgresql(dot)org" <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Increase test coverage in RI_FKey_pk_upd_check_required()
Date: 2019-01-16 16:39:57
Message-ID: CAKFQuwY+9NKT5XEXnvKZYma0VVKYG7MHSqfUmH5wvMdBFuGFTw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wednesday, January 16, 2019, Peter Eisentraut <peter(at)eisentraut(dot)org>
wrote:

> Increase test coverage in RI_FKey_pk_upd_check_required()
>
> This checks the case where the primary key has at least one null
> column.
>

Sorry if this seems pedantic but you are testing where a unique index has
at least one null column value. A primary key, per the docs, cannot
contain null in any of its columns. I read the commit message and thought
maybe that had changed while I wasn’t looking...

David J.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2019-01-16 19:30:46 pgsql: Reorganize planner code moved in b60c39759908
Previous Message Peter Eisentraut 2019-01-16 16:09:37 pgsql: Add test case for ON DELETE NO ACTION/RESTRICT