| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | "pgsql-committers(at)lists(dot)postgresql(dot)org" <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Increase test coverage in RI_FKey_pk_upd_check_required() |
| Date: | 2019-01-16 20:00:10 |
| Message-ID: | 8ff1cfd7-7b30-9e10-84d7-f68123c5e2b2@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 16/01/2019 17:39, David G. Johnston wrote:
> On Wednesday, January 16, 2019, Peter Eisentraut <peter(at)eisentraut(dot)org
> <mailto:peter(at)eisentraut(dot)org>> wrote:
>
> Increase test coverage in RI_FKey_pk_upd_check_required()
>
> This checks the case where the primary key has at least one null
> column.
>
>
> Sorry if this seems pedantic but you are testing where a unique index
> has at least one null column value. A primary key, per the docs, cannot
> contain null in any of its columns. I read the commit message and
> thought maybe that had changed while I wasn’t looking...
Yeah, it's the foreign key referencing the primary key in this case.
You are correct, the message is a bit wrong.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2019-01-17 05:41:21 | pgsql: postgres_fdw: Remove duplicate code in DML execution callback fu |
| Previous Message | Alvaro Herrera | 2019-01-16 19:30:46 | pgsql: Reorganize planner code moved in b60c39759908 |