| From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] Planning counters in pg_stat_statements |
| Date: | 2018-01-11 23:15:30 |
| Message-ID: | CAJrrPGfgvm9X3_10SNpz5Y3sZ2y0tvTTFQEx4Tr16rtiMjkrDg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 11, 2018 at 10:00 PM, Thomas Munro <
thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> On Thu, Jan 11, 2018 at 7:36 PM, Haribabu Kommi
> <kommi(dot)haribabu(at)gmail(dot)com> wrote:
>
> > + OUT plans int8,
> >
> > Addition of this column is good to find out how many time the plan is
> > generated
> > for the same query. But I am thinking "plans" column name may confuse?
>
> What else would you call that? It's the number of plans that have
> been created. It sits nicely beside "calls" don't you think? I could
> change it to "plan_count" but that's longer and not like "calls".
>
OK.
I checked the latest patch and it is working fine and I don't have any
further comments. Marked the patch as "ready for committer".
Regards,
Hari Babu
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-01-11 23:19:08 | Re: IndexTupleDSize macro seems redundant |
| Previous Message | Vaishnavi Prabakaran | 2018-01-11 23:12:35 | Re: [HACKERS] PATCH: Batch/pipelining support for libpq |