Re: BUG #14314: Mismatch of comment of a function.

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: t(dot)katsumata1122(at)gmail(dot)com
Cc: "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14314: Mismatch of comment of a function.
Date: 2016-09-12 01:04:14
Message-ID: CAJrrPGcis2R7jW8Cb_UKdC4qmB0cMxtgJAmEyCm_pBuSpx0OLg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Sep 7, 2016 at 11:42 PM, <t(dot)katsumata1122(at)gmail(dot)com> wrote:

> The following bug has been logged on the website:
>
> Bug reference: 14314
> Logged by: Tomonari Katsumata
> Email address: t(dot)katsumata1122(at)gmail(dot)com
> PostgreSQL version: 9.6rc1
> Operating system: Source Code
> Description:
>
> Hello.
>
> I noticed that it isn't proper for a comment for
> transformOnConflictClause.
>
> ---
> 940 /*
> 941 * transformSelectStmt -
> 942 * transforms an OnConflictClause in an INSERT
> 943 */
> 944 static OnConflictExpr *
> 945 transformOnConflictClause(ParseState *pstate,
> 946 OnConflictClause *onConflictClause)
> 947 {
> ----
>
> It should be "transformOnConflictClause" rather than
> "transformSelectStmt".
>

Attached patch fixes the reported problem. The patch needs to be
applied till the 9.5 stable branch where the on conflict is introduced.

Regards,
Hari Babu
Fujitsu Australia

Attachment Content-Type Size
function_header_comment_fix.patch application/octet-stream 395 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message lilacyd 2016-09-13 00:34:01 BUG #14323: char input does not work
Previous Message Jürgen Strobel 2016-09-10 19:28:08 Re: BUG #14321: pg_basebackup --xlog-method=stream fails