From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
---|---|
To: | Antonin Houska <ah(at)cybertec(dot)at> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Attempt to consolidate reading of XLOG page |
Date: | 2019-04-12 08:48:33 |
Message-ID: | CAJrrPGcdQTfNhXPoYthqjmxvk1YbHPDDP+fwsXQUQqUL2yRJPA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Apr 12, 2019 at 2:06 AM Antonin Houska <ah(at)cybertec(dot)at> wrote:
> While working on the instance encryption I found it annoying to apply
> decyption of XLOG page to three different functions. Attached is a patch
> that
> tries to merge them all into one function, XLogRead(). The existing
> implementations differ in the way new segment is opened. So I added a
> pointer
> to callback function as a new argument. This callback handles the specific
> ways to determine segment file name and to open the file.
>
> I can split the patch into multiple diffs to make detailed review easier,
> but
> first I'd like to hear if anything is seriously wrong about this
> design. Thanks.
>
I didn't check the code, but it is good to combine all the 3 page read
functions
into one instead of spreading the logic.
Regards,
Haribabu Kommi
Fujitsu Australia
From | Date | Subject | |
---|---|---|---|
Next Message | Haribabu Kommi | 2019-04-12 09:34:13 | Transparent data encryption support as an extension |
Previous Message | Fabien COELHO | 2019-04-12 08:38:49 | improve PQexec documentation |