| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, ashutosh(dot)bapat(dot)oss(at)gmail(dot)com, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Crashes on a partition whose concurrent detach never finished |
| Date: | 2026-09-11 05:11:21 |
| Message-ID: | CAJpy0uDFU9CboFp1OvLV4tAtO+WjyMDYmPmZr_1_3kA3s3MnSw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 10, 2026 at 7:40 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
> On Thu, Sep 10, 2026 at 5:37 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> > > ~~~
> > >
> > > Given that we are treating a detach-pending partition as an individual
> > > table for publication decisions, the changes in patch-003 (pg19
> > > regression) look correct to me. The changes in relcache.c correctly
> > > treat the detach-pending partition as an individual table.
> > >
> >
> > I haven't had a chance to reveiw 003 yet as 001 itself was
> > problematic. Will review it tomorrow.
> >
>
> Here is a rebased version of 003 that applies independently on both
> HEAD and pg19. This should make reviewing patch-003 separately easier.
>
Okay, the fix looks good. I verified that it fixes the crash on HEAD.
But it would be good to change the fix slightly to be consistent with
001. See the attached changes for reference.
thanks
Shveta
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-patch003-check-improvement.patch | application/octet-stream | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2026-09-11 05:26:49 | Re: pg_get_*_ddl() needs a redesign |
| Previous Message | Tom Lane | 2026-09-11 04:55:54 | Re: pg_get_*_ddl() needs a redesign |