| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, saurabh singh <saurabh(dot)singh214(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-10-28 08:57:53 |
| Message-ID: | CAJpy0uCan_L-WfD28COD+nuVaFvDkTrxdza2Kj+PABPuywn65w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 28, 2026 at 10:50 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Tue, Oct 27, 2026 at 5:03 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> >
> > Please find the updated patches v85. I also incorporated Shveta's doc
> > suggestion[1] into the v85-0004 patch.
>
> Thanks for the patches. You did not post v85-0004, which you are
> referring to in the above comment.
>
> I reviewed 001 mainly. A few comments:
>
Reviewed 002 and 003, one minor comment in 002, we have error messages
like below:
+ errdetail("Dropping the conflict log table requires a lock that
prepared transactions of this subscription may be holding."),
+ errdetail("Prepared transactions of the subscription may hold a lock
on its conflict log table."),
The second message uses the ambiguous "its". It would be clearer to
explicitly refer to the 'subscription’s conflict log table', as in the
first message.
Suggestion:
"Prepared transactions of the subscription may hold a lock on the
subscription’s conflict log table."
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Iliia Khaprov | 2026-10-28 09:05:58 | Re: [PATCH] Remove useless ORDER BY from scalar subqueries |
| Previous Message | David Steele | 2026-10-28 08:56:25 | Re: Return pg_control from pg_backup_stop(). |