| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: Initial table sync copies the whole table when it is no longer published |
| Date: | 2026-11-18 05:10:23 |
| Message-ID: | CAJpy0uCH60rxh1_Z9yEAjacwFJuy6CgRZoDfY5Y0jYqJNRdwnQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 18, 2026 at 9:48 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> On Wed, Nov 18, 2026 at 2:39 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > Good point Ajin. I did not think of it earlier, but on analysing it
> > now, I think there is a way out without the race: since
> > disable_on_error can be changed on a disabled sub, the user can
> > temporarily set 'disable_on_error=false' on disabled sub, then ENABLE
> > the sub, then REFRESH PUBLICATION, and then set disable_on_error back
> > to true. I tested this with the patch, and it works.
> >
>
> Yes, that works as a workaround.
>
> >
> > As you said, this applies to all tablesync errors caused by
> > publisher-side changes, so I think documenting it would be better done
> > separately,e.g. as a note in the disable_on_error description?
> > Thoughts? But if others feel that we can combine it in this patch, I
> > am okay to do that.
>
> Yes, a note in the disable_on_error description sounds good.
Done. Attached v3-0002. No change in 0001.
> On Wed, Nov 18, 2026 at 2:40 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > I missed mentioning that alternatively, the table can be published
> > again on the publisher before re-enabling (if necessary).
> >
>
> I don't think users would want to do that if they removed the table
> from the publication deliberately. It also isn't an option for an
> UNLOGGED table like in Shlok's example, which can't be published at
> all, or for a table that has been dropped on the publisher.
Okay, I have still added a generic line about this in the doc without
mentioning any specific resolution in this context.
thanks
Shveta
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0002-Doc-Explain-how-to-recover-a-subscription-disable.patch | application/octet-stream | 2.4 KB |
| v3-0001-Do-not-copy-the-whole-table-in-tablesync-when-no-.patch | application/octet-stream | 7.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-11-18 05:11:40 | Re: Fix for consume_xids advancing XIDs incorrectly |
| Previous Message | Fujii Masao | 2026-11-18 04:44:02 | Re: 041_checkpoint_at_promote.pl might fail due to race condition on child kill |