| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: Initial table sync copies the whole table when it is no longer published |
| Date: | 2026-11-18 04:17:59 |
| Message-ID: | CAFPTHDZBU1pX_6F7-xsSP0djBMCzNykK54Xyt51Jv47rYQQnGA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 18, 2026 at 2:39 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> Good point Ajin. I did not think of it earlier, but on analysing it
> now, I think there is a way out without the race: since
> disable_on_error can be changed on a disabled sub, the user can
> temporarily set 'disable_on_error=false' on disabled sub, then ENABLE
> the sub, then REFRESH PUBLICATION, and then set disable_on_error back
> to true. I tested this with the patch, and it works.
>
Yes, that works as a workaround.
>
> As you said, this applies to all tablesync errors caused by
> publisher-side changes, so I think documenting it would be better done
> separately,e.g. as a note in the disable_on_error description?
> Thoughts? But if others feel that we can combine it in this patch, I
> am okay to do that.
Yes, a note in the disable_on_error description sounds good.
On Wed, Nov 18, 2026 at 2:40 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> I missed mentioning that alternatively, the table can be published
> again on the publisher before re-enabling (if necessary).
>
I don't think users would want to do that if they removed the table
from the publication deliberately. It also isn't an option for an
UNLOGGED table like in Shlok's example, which can't be published at
all, or for a table that has been dropped on the publisher.
Regards,
Ajin Cherian
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stepan Neretin | 2026-11-18 04:19:17 | Re: FATAL: could not send end-of-streaming message to primary: no COPY in progress |
| Previous Message | solai v | 2026-11-18 04:12:06 | Re: Wrong varnullingrels for MERGE into a trigger-updatable view |